Add ECMAScript comment to JSMin.cs/NextCharExcludingComments() #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow! I'm super impressed that you took the time to modify Jsmin, it's not a nice or easy task to do :) The source of JsMin is actually here https://github.com/Shazwazza/JsMinSharp which has unit tests. Any chance you would be able to send a PR to there with a unit test? Then we can get this re-merged back into both CDF and Smidge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECMAScript states that <!--SingleLineCommentChars--> is also the comment style.
Please refer to https://www.ecma-international.org/publications/files/ECMA-ST/Ecma-262.pdf page 773.
I just add this pattern to JSMin.cs/NextCharExcludingComments() to avoid exception.